Only the OAuth2 auth strategy was using the state parameter, which should be used as described in the RFC. The other auth strategies such as GitHub, GitLab or Google were lacking the state parameter. This change adds the required state parameter as well as enabling PKCE support on providers where it's possible. Signed-off-by: Erik Michelson <github@erik.michelson.eu>
30 lines
986 B
JavaScript
30 lines
986 B
JavaScript
'use strict'
|
|
|
|
const Router = require('express').Router
|
|
const passport = require('passport')
|
|
const GoogleStrategy = require('passport-google-oauth20').Strategy
|
|
const config = require('../../../config')
|
|
const { passportGeneralCallback } = require('../utils')
|
|
|
|
const googleAuth = module.exports = Router()
|
|
|
|
passport.use(new GoogleStrategy({
|
|
clientID: config.google.clientID,
|
|
clientSecret: config.google.clientSecret,
|
|
callbackURL: config.serverURL + '/auth/google/callback',
|
|
userProfileURL: 'https://www.googleapis.com/oauth2/v3/userinfo',
|
|
pkce: true,
|
|
state: true
|
|
}, passportGeneralCallback))
|
|
|
|
googleAuth.get('/auth/google', function (req, res, next) {
|
|
passport.authenticate('google', { scope: ['profile'], hostedDomain: config.google.hostedDomain })(req, res, next)
|
|
})
|
|
// google auth callback
|
|
googleAuth.get('/auth/google/callback',
|
|
passport.authenticate('google', {
|
|
successReturnToOrRedirect: config.serverURL + '/',
|
|
failureRedirect: config.serverURL + '/'
|
|
})
|
|
)
|