From f115b2d0845c1c2c9e92615b708c152eef2cc202 Mon Sep 17 00:00:00 2001 From: Erik Michelson Date: Thu, 18 Jun 2026 23:42:40 +0200 Subject: [PATCH] fix(views): fail-safe opengraph tag HTML rendering Signed-off-by: Erik Michelson --- public/views/hedgedoc/head.ejs | 4 ++-- public/views/pretty.ejs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/public/views/hedgedoc/head.ejs b/public/views/hedgedoc/head.ejs index 27ecffb7..c6075f6e 100644 --- a/public/views/hedgedoc/head.ejs +++ b/public/views/hedgedoc/head.ejs @@ -6,9 +6,9 @@ <%- include('../includes/favicon') %> <% for (var og in opengraph) { %> -<% if (opengraph.hasOwnProperty(og) && String(opengraph[og]).trim() !== '') { %> +<% if (Object.keys(opengraph).includes(og) && typeof opengraph[og] === 'string' && opengraph[og].trim() !== '') { %> -<% }} if (!opengraph.hasOwnProperty('image')) { %> +<% }} if (!Object.keys(opengraph).includes('image')) { %> diff --git a/public/views/pretty.ejs b/public/views/pretty.ejs index bddb1db5..dfbb89ce 100644 --- a/public/views/pretty.ejs +++ b/public/views/pretty.ejs @@ -15,9 +15,9 @@ <% } %> <% for (var og in opengraph) { %> - <% if (opengraph.hasOwnProperty(og) && typeof opengraph[og] === 'string' && opengraph[og].trim() !== '') { %> + <% if (Object.keys(opengraph).includes(og) && typeof opengraph[og] === 'string' && opengraph[og].trim() !== '') { %> - <% }} if (!opengraph.hasOwnProperty('image')) { %> + <% }} if (!Object.keys(opengraph).includes('image')) { %>