Fixed if using splice in loop should always decrement index or might out of array range

2015-09-26 10:25:00 +08:00
parent 3683a6dd34
commit 332413bcaa
2 changed files with 12 additions and 4 deletions
--- a/public/js/history.js
+++ b/public/js/history.js
@@ -123,8 +123,10 @@ function addHistory(id, text, time, tags, notehistory) {

 function removeHistory(id, notehistory) {
    for (var i = 0; i < notehistory.length; i++) {
-        if (notehistory[i].id == id)
+        if (notehistory[i].id == id) {
            notehistory.splice(i, 1);
+			i--;
+		}
    }
    return notehistory;
 }